This repository was archived by the owner on May 15, 2025. It is now read-only.
Add more tests to Alefeld and fix bugs #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #58 +/- ##
==========================================
+ Coverage 91.51% 91.64% +0.12%
==========================================
Files 16 16
Lines 778 778
==========================================
+ Hits 712 713 +1
+ Misses 66 65 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Oddly the merged version of your PR failed tests (https://github.com/SciML/SimpleNonlinearSolve.jl/actions/runs/4573566745/jobs/8074148400) even though CI was just fine in the PR. If you run master locally do you see these issues? |
Merged
|
I just ran the code locally, and this time all the tests passed. |
|
Looks like it's good. I am not sure what I saw there. |
|
I think issue #34 has been resolved. If you agree, could you please close it? Thank you:) @ChrisRackauckas |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are some new things added to the repository: